Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite MacroEvaluator to support flatten, and container-making macros #1019

Merged
merged 10 commits into from
Jan 2, 2025

Adds suggested changes

14f315d
Select commit
Loading
Failed to load commit list.
Merged

Rewrite MacroEvaluator to support flatten, and container-making macros #1019

Adds suggested changes
14f315d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 2, 2025 in 1s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 82.02020% with 89 lines in your changes missing coverage. Please review.

Please upload report for BASE (ion-11-encoding@620228b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...n/java/com/amazon/ion/impl/macro/MacroEvaluator.kt 81.11% 51 Missing and 30 partials ⚠️
...main/java/com/amazon/ion/impl/macro/Environment.kt 0.00% 5 Missing ⚠️
.../main/java/com/amazon/ion/impl/macro/Expression.kt 50.00% 2 Missing ⚠️
src/main/java/com/amazon/ion/util/Assumptions.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                 @@
##             ion-11-encoding    #1019   +/-   ##
==================================================
  Coverage                   ?   70.81%           
  Complexity                 ?     7375           
==================================================
  Files                      ?      214           
  Lines                      ?    29533           
  Branches                   ?     5319           
==================================================
  Hits                       ?    20914           
  Misses                     ?     6960           
  Partials                   ?     1659

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov