Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hoisted Text Span Symbol Table Bug #1043

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Conversation

rmarrowstone
Copy link
Contributor

@rmarrowstone rmarrowstone commented Jan 28, 2025

Fixes #1042

I'm truly not sure if there is impact with the bug, but the fix is trivial, so it seemed best just to fix it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rmarrowstone rmarrowstone marked this pull request as ready for review January 28, 2025 18:14
Copy link
Contributor

@tgregg tgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@rmarrowstone rmarrowstone merged commit a5ba511 into master Jan 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Symbol Lookup with Hoisted Text Span
2 participants