Fixes incremental reading of FlexSyms. #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
approved these changes
Jun 27, 2024
| return consumer -> consumer.accept(new Expectation<>( | ||
| String.format("field(%d, %d)", expectedStartIndex, expectedEndIndex), | ||
| cursor -> { | ||
| //assertNotNull(cursor.fieldTextMarker.typeId); |
There was a problem hiding this comment.
Should this be uncommented or removed?
tgregg
force-pushed
the
cursor-read-tagless-reorder
branch
from
bce90be to
a6a6a37
Compare
tgregg
force-pushed
the
cursor-read-tagless-reorder-flexsym-incremental
branch
from
9a4b970 to
5674e82
Compare
tgregg
force-pushed
the
cursor-read-tagless-reorder-flexsym-incremental
branch
from
5674e82 to
c985cf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Before this PR, FlexSyms could not be read incrementally (i.e., without all bytes available up front) because the relevant methods did not distinguish between the signed integer value
-1and the-1commonly used to convey that the end of the input has been reached. This PR fixes that defect by usingMarkerto store the FlexSym's value, and a boolean return to convey whether the end of input was reached.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.