Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cardinality enum to match spec #907

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

popematt
Copy link
Contributor

@popematt popematt commented Jul 2, 2024

Issue #, if available:

None

Description of changes:

Changes the ParameterCardinality enum so that the variants match the terms used in the spec.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@popematt popematt requested a review from tgregg July 2, 2024 18:24
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (ion-11-encoding@1c8be59). Learn more about missing BASE report.

Files Patch % Lines
src/main/java/com/amazon/ion/impl/macro/Macro.kt 44.44% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             ion-11-encoding     #907   +/-   ##
==================================================
  Coverage                   ?   69.63%           
  Complexity                 ?     6461           
==================================================
  Files                      ?      184           
  Lines                      ?    25599           
  Branches                   ?     4599           
==================================================
  Hits                       ?    17825           
  Misses                     ?     6387           
  Partials                   ?     1387           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@popematt popematt merged commit acf2ebc into amazon-ion:ion-11-encoding Jul 2, 2024
20 of 36 checks passed
tgregg pushed a commit that referenced this pull request Sep 9, 2024
tgregg pushed a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants