-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): deb package on release #518
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I can see from the log https://github.com/Ph0enixKM/amber-workflow-tests/actions/runs/11464290559/job/31900143129 the deb package was generated. I think that the issue is that I have to specify the file to upload because doesn't upload all the files in a specific folder. |
@Ph0enixKM can you try now? |
@Mte90 I'll finish fixing master and then I'll try it again |
Let's merge this fix (#535) and then I'll test this branch. |
After testing the new changes, it seems that it still does not work. I got no
|
I did that changes, automatically the file is created with the architecture where it is compiled. |
@@ -192,6 +197,8 @@ jobs: | |||
# Parse out what we just built and upload it to scratch storage | |||
echo "paths<<EOF" >> "$GITHUB_OUTPUT" | |||
jq --raw-output ".upload_files[]" dist-manifest.json >> "$GITHUB_OUTPUT" | |||
AMBER_VERSION=$($AMBER --version) | |||
echo "$PWD/target/distrib/amber_${AMBER_VERSION}-1_amd64.sh" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I though that you're going to put the path to the .deb
file here. What is amber_*-1_amb64.sh
?
path: plan-dist-manifest.json | ||
path: | | ||
plan-dist-manifest.json | ||
amber_*.deb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we add it here before compiling the package?
Ref: #289
So I did an update to the toml file, the ci will use cargo deb to generate the package, tested locally and works.
I am not sure how the CI works, I think that I am putting the file in the right path but I am not sure if it is the right job.