Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary id on textarea #440

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jan 24, 2024

Why and what is being done.

This was unused and may cause accessibility concerns if there is more than one recaptcha on the page due to multiple elements with the same id

Fixes #439

Pre-Merge Checklist

  • CHANGELOG.md updated with short summary

This was unused and may cause accessibility concerns if there is more than one recaptcha on the page due to multiple elements with the same id
Copy link
Collaborator

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah can't see it being used for anything
only gotcha might be someone using it for styling or custom js but kinda doubt that

@grosser grosser merged commit e87c504 into ambethia:master Jan 24, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

id on textarea causes duplicate ids if recaptcha_tags is called twice on the same page
2 participants