Skip to content

Commit

Permalink
Clarify TODO comment about sortQueryParams hack
Browse files Browse the repository at this point in the history
  • Loading branch information
amiel committed Oct 26, 2018
1 parent 1ad9944 commit 6ace782
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions addon/mixins/url-templates.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,9 @@ export default Mixin.create({

// HACK: Prevent query/queryRecord from appending query params to urls, we
// can do that in the template.
// TODO: Use dataForRequest when ds-improved-ajax lands
// (https://github.com/emberjs/data/pull/3099)
// TODO: ember-data plans to implement better hooks for customizing the
// request. Hopefully in the future, this hack can be removed and another
// hook used instead.
sortQueryParams(/* params */) {
return {};
},
Expand Down

0 comments on commit 6ace782

Please sign in to comment.