Add service account values to read and import #525

pjsier · 2023-10-09T20:09:56Z

Add service account values to read and import

Adds disable_user and target_user to minio_service_account on import which were previously missing. The more important one is minio_service_account, but in case disable_user presented issues I added it as well. disable_user is not checked for errors since it's pulled from the account status which is already checked.

I didn't include secret_key because it's computed and unless I'm misunderstanding the implementation wouldn't be necessary here.

I may have missed things in the implementation, happy to make changes!

Closing issues

Closes: Service account read & import do not read all properties, e.g.: target_user. #481

felladrin · 2023-10-24T12:24:33Z

Thank you, @pjsier!

(cherry picked from commit cf0c88d)

* Update module github.com/aws/aws-sdk-go to v1.45.6 (#515) (cherry picked from commit 4953af3) * Update crazy-max/ghaction-import-gpg action to v6 (#516) (cherry picked from commit ee28b90) * Handle empty service account policy (#518) (cherry picked from commit 779d356) * Update repository URL (#520) (cherry picked from commit 7a680c7) * Update project to Go v1.20 (#519) (cherry picked from commit be07cf7) * Destroy object versions on bucket force_destroy (#524) (cherry picked from commit a107f61) * Update goreleaser-action to v5 and add permission for the workflow to attach binaries to GitHub Releases (#521) (cherry picked from commit c06ddba) * Add Noncurrent Version expiration to ilm policy (#526) Co-authored-by: Nicolas De Jesus <[email protected]> (cherry picked from commit f031109) * Bump golang.org/x/net from 0.15.0 to 0.17.0 (#530) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.15.0 to 0.17.0. - [Commits](golang/net@v0.15.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit ec7f197) * Add service account values to read and import (#525) (cherry picked from commit cf0c88d) * Recreate user if it's not found anymore (#534) Fixes #511 (cherry picked from commit 50bc121) * Bump google.golang.org/grpc from 1.58.0 to 1.58.3 (#535) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.58.0 to 1.58.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.58.0...v1.58.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 5fa1a1b) * Revert "Update repository URL (#520)" (#538) This reverts commit 7a680c7. (cherry picked from commit 8a0b114) * Update target branches of GitHub Actions to `v1` branch --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Artem Usenko <[email protected]> Co-authored-by: Jonathan Buch <[email protected]> Co-authored-by: Pat Sier <[email protected]> Co-authored-by: ndejesus <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tobias Krischer <[email protected]>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [minio](https://registry.terraform.io/providers/aminueza/minio) ([source](https://github.com/aminueza/terraform-provider-minio)) | required_provider | minor | `~> 1.18.0` -> `~> 1.20.0` | --- > ⚠ **Warning** > > Some dependencies could not be looked up. Check the warning logs for more information. --- ### Release Notes <details> <summary>aminueza/terraform-provider-minio (minio)</summary> ### [`v1.20.1`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v1.20.1) [Compare Source](aminueza/terraform-provider-minio@v1.20.0...v1.20.1) #### What's Changed - Fix null expiration date handling by [@pjsier](https://github.com/pjsier) in aminueza/terraform-provider-minio#545 - Update terraform version to 1.5.7 in GitHub Action by [@felladrin](https://github.com/felladrin) in aminueza/terraform-provider-minio#540 **Full Changelog**: aminueza/terraform-provider-minio@v1.20.0...v1.20.1 > **Note** > [v1](https://github.com/aminueza/terraform-provider-minio/tree/v1) of the provider is now under maintenance mode. If you can, it's advised to upgrade to `v2`. ### [`v1.20.0`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v1.20.0) [Compare Source](aminueza/terraform-provider-minio@v1.19.0...v1.20.0) #### What's Changed - Update module github.com/aws/aws-sdk-go to v1.45.6 by [@renovate](https://github.com/renovate) in aminueza/terraform-provider-minio#515 - Update crazy-max/ghaction-import-gpg action to v6 by [@renovate](https://github.com/renovate) in aminueza/terraform-provider-minio#516 - Handle empty service account policy by [@ArataEM](https://github.com/ArataEM) in aminueza/terraform-provider-minio#518 - Go 1.20 by [@BuJo](https://github.com/BuJo) in aminueza/terraform-provider-minio#519 - Destroy object versions on bucket force_destroy by [@pjsier](https://github.com/pjsier) in aminueza/terraform-provider-minio#524 - Update goreleaser-action to v5 and add permission for the workflow to attach binaries to GitHub Releases by [@felladrin](https://github.com/felladrin) in aminueza/terraform-provider-minio#521 - Add Noncurrent Version expiration to ilm policy by [@ndejesus](https://github.com/ndejesus) in aminueza/terraform-provider-minio#526 - Bump golang.org/x/net from 0.15.0 to 0.17.0 by [@dependabot](https://github.com/dependabot) in aminueza/terraform-provider-minio#530 - Add service account values to read and import by [@pjsier](https://github.com/pjsier) in aminueza/terraform-provider-minio#525 - feat: recreate user if not found anymore by [@tobikris](https://github.com/tobikris) in aminueza/terraform-provider-minio#534 - Bump google.golang.org/grpc from 1.58.0 to 1.58.3 by [@dependabot](https://github.com/dependabot) in aminueza/terraform-provider-minio#535 #### New Contributors - [@ndejesus](https://github.com/ndejesus) made their first contribution in aminueza/terraform-provider-minio#526 **Full Changelog**: aminueza/terraform-provider-minio@v1.18.0...v1.20.0 > **Note** > This release replaces v1.18.1 and v1.18.2, which are unavailable on https://registry.terraform.io/providers/aminueza/minio as they were built with an outdated GPG key. It also replaces v1.18.3 and v1.19.0, which couldn't be installed due the issue [#531](aminueza/terraform-provider-minio#531). ### [`v1.19.0`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v1.19.0) [Compare Source](aminueza/terraform-provider-minio@v1.18.3...v1.19.0) Changes on this Release: - Update crazy-max/ghaction-import-gpg action to v6 ([#516](aminueza/terraform-provider-minio#516)) - Handle empty service account policy ([#518](aminueza/terraform-provider-minio#518)) - Update repository URL ([#520](aminueza/terraform-provider-minio#520)) - Destroy object versions on bucket force_destroy ([#524](aminueza/terraform-provider-minio#524)) - Add Noncurrent Version expiration to ilm policy ([#526](aminueza/terraform-provider-minio#526)) **Full Changelog**: aminueza/terraform-provider-minio@v1.18.0...v1.19.0 > **Note** > This release replaces v1.18.1 and v1.18.2, which are unavailable on https://registry.terraform.io/providers/aminueza/minio as they were built with an outdated GPG key. It also replaces v1.18.3, which couldn't be installed due the issue [#531](aminueza/terraform-provider-minio#531). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.eevans.me/shosti/eevans-infra/pulls/10 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

Add service account values to read and import

5e40f65

pjsier mentioned this pull request Oct 9, 2023

Service account read & import do not read all properties, e.g.: target_user. #481

Closed

1 task

felladrin approved these changes Oct 24, 2023

View reviewed changes

felladrin merged commit cf0c88d into aminueza:master Oct 24, 2023
2 checks passed

felladrin pushed a commit that referenced this pull request Nov 4, 2023

Add service account values to read and import (#525)

f83e303

felladrin pushed a commit that referenced this pull request Nov 4, 2023

Add service account values to read and import (#525)

528ba33

(cherry picked from commit cf0c88d)

This was referenced Nov 7, 2023

minio_iam_service_account resource is updated on every run in 2.0.0 #544

Open

Parse service account user from LDAP str #547

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add service account values to read and import #525

Add service account values to read and import #525

pjsier commented Oct 9, 2023

felladrin commented Oct 24, 2023

Add service account values to read and import #525

Add service account values to read and import #525

Conversation

pjsier commented Oct 9, 2023

Add service account values to read and import

Closing issues

felladrin commented Oct 24, 2023