Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name, description and expiration support for service accounts #594

Merged
merged 5 commits into from
Nov 10, 2024

Conversation

ribetm
Copy link
Contributor

@ribetm ribetm commented Nov 9, 2024

Add name, description and expiration support for service accounts

Changes

Allows setting 3 new attributes on service accounts:

  • name: optional string
  • description: optional string
  • expiration: optional date, in RFC3339 format

Compatibility

All of these fields are optional, making it backward compatible.

Users may see a change on expiration from null to 1970-01-01T00:00:00Z (which are equivalent), but only if something else is updated. As far as I know there is no way around this, since Terraform considers null as untracked while Minio sees it as either epoch for creations, or as no change for updates.

Remarks

I've included argument validation matching Minio's API requirements:

  • name must be 32 bytes max
  • description must be 256 bytes max
  • expiration must be between +15mn and +1y

Allowing invalid values to be sent to the API would throw relatively unclear errors, especially without verbose logging

@ribetm
Copy link
Contributor Author

ribetm commented Nov 9, 2024

When I generated the docs with task generate-docs, it changed more than what I added. I only included what's related to my PR for now.

With a quick glance at the other changes, it may seem related to the new v3 schema

@felladrin
Copy link
Collaborator

Congrats on your first contribution to this repository, @ribetm! All clear! Let's merge and release it as v3.1.0! 🎉

@felladrin felladrin merged commit 5dc95e9 into aminueza:main Nov 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants