Add name, description and expiration support for service accounts #594
+249
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add name, description and expiration support for service accounts
Changes
Allows setting 3 new attributes on service accounts:
Compatibility
All of these fields are optional, making it backward compatible.
Users may see a change on expiration from
null
to1970-01-01T00:00:00Z
(which are equivalent), but only if something else is updated. As far as I know there is no way around this, since Terraform considersnull
as untracked while Minio sees it as either epoch for creations, or asno change
for updates.Remarks
I've included argument validation matching Minio's API requirements:
Allowing invalid values to be sent to the API would throw relatively unclear errors, especially without verbose logging