-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DiffUtil Callback #59
Conversation
abstract class FrogoRecyclerViewAdapter<T> : | ||
RecyclerView.Adapter<FrogoRecyclerViewHolder<T>>() { | ||
|
||
abstract class FrogoRecyclerViewAdapter<T> : CoreFrogoRecyclerViewAdapter<T, FrogoRecyclerViewHolder<T>>() { |
Check warning
Code scanning / detekt
Too many functions inside a/an file/class/object/interface always indicate a violation of the single responsibility principle. Maybe the file/class/object/interface wants to manage too many things at once. Extract functionality which clearly belongs together. Warning
*/ | ||
interface IFrogoSingleRvBinding<T, VB : ViewBinding> { | ||
|
||
interface IFrogoRvSingleton<T> { |
Check warning
Code scanning / detekt
Too many functions inside a/an file/class/object/interface always indicate a violation of the single responsibility principle. Maybe the file/class/object/interface wants to manage too many things at once. Extract functionality which clearly belongs together. Warning
*/ | ||
|
||
|
||
abstract class CoreFrogoRecyclerViewAdapter<T, VH : CoreFrogoRecyclerViewHolder<T>> : RecyclerView.Adapter<VH>() { |
Check warning
Code scanning / detekt
Too many functions inside a/an file/class/object/interface always indicate a violation of the single responsibility principle. Maybe the file/class/object/interface wants to manage too many things at once. Extract functionality which clearly belongs together. Warning
* Base Of Core FrogoRecyclerViewHolder | ||
*/ | ||
|
||
protected var notifyListener = object : FrogoRecyclerNotifyListener<T> { |
Check warning
Code scanning / detekt
Too many functions inside a/an file/class/object/interface always indicate a violation of the single responsibility principle. Maybe the file/class/object/interface wants to manage too many things at once. Extract functionality which clearly belongs together. Warning
@@ -20,7 +20,8 @@ | |||
* com.frogobox.recycler | |||
* | |||
*/ | |||
open class FrogoSingleRv<T> : FrogoSingleRvBase<T>(), IFrogoSingleRv<T> { | |||
|
|||
open class FrogoSingleRv<T> : FrogoSingleRvBase<T>(), IFrogoRv<T> { |
Check warning
Code scanning / detekt
Too many functions inside a/an file/class/object/interface always indicate a violation of the single responsibility principle. Maybe the file/class/object/interface wants to manage too many things at once. Extract functionality which clearly belongs together. Warning
@@ -0,0 +1,154 @@ | |||
package com.frogobox.recycler.core |
Check warning
Code scanning / detekt
Checks whether files end with a line separator. Warning
} | ||
}) | ||
|
||
open fun adapterAreItemsTheSame(oldItem: T & Any, newItem: T & Any): Boolean { |
Check warning
Code scanning / detekt
A function that only returns a constant is misleading. Consider declaring a constant instead Warning
return false | ||
} | ||
|
||
open fun adapterAreContentsTheSame(oldItem: T & Any, newItem: T & Any): Boolean { |
Check warning
Code scanning / detekt
A function that only returns a constant is misleading. Consider declaring a constant instead Warning
|
||
/* | ||
/** |
Check warning
Code scanning / detekt
An abstract class is unnecessary and can be refactored. An abstract class should have both abstract and concrete properties or functions. An abstract class without a concrete member can be refactored to an interface. An abstract class without an abstract member can be refactored to a concrete class. Warning
@@ -0,0 +1,24 @@ | |||
package com.frogobox.recycler.core |
Check warning
Code scanning / detekt
Checks whether files end with a line separator. Warning
No description provided.