Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL CI #22

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add CodeQL CI #22

wants to merge 6 commits into from

Conversation

kostyanf14
Copy link
Contributor

No description provided.

@kostyanf14 kostyanf14 requested a review from just806me June 24, 2022 12:59
@@ -1,5 +1,6 @@
class Api::ApplicationController < ApplicationController
skip_before_action :verify_authenticity_token
#lgtm[rb/csrf-protection-disabled]

Check notice

Code scanning / Rubocop

Comments should start with a space.

Layout/LeadingCommentSpace: Missing space after `#`.
@@ -1,5 +1,6 @@
class Api::ApplicationController < ApplicationController
skip_before_action :verify_authenticity_token
#lgtm[rb/csrf-protection-disabled]
skip_before_action :verify_authenticity_token # ; lgtm

Check failure

Code scanning / CodeQL

CSRF protection weakened or disabled

Potential CSRF vulnerability due to forgery protection being disabled or weakened.
@kostyanf14 kostyanf14 force-pushed the master branch 4 times, most recently from 47acfcf to 902389b Compare June 26, 2022 17:07
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
We want to disable this behavior since the request API
client handles the session instead of Rails.

Signed-off-by: Kostiantyn Kostiuk <[email protected]>
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants