Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized Todos pages #74

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Conversation

brunocabral88
Copy link
Contributor

@brunocabral88 brunocabral88 commented Jun 3, 2020

References #61

Implemented Localization for the Todos pages, included pt-br translation for its Home page. (You can test by accessing /Todos/Index?culture=pt). The navbar is also localized.
Other controllers pages still need to be translated.

image

If you have any suggestion or addition please let me know :)

@codecov-commenter
Copy link

Codecov Report

Merging #74 into develop will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #74      +/-   ##
===========================================
- Coverage    31.14%   30.99%   -0.16%     
===========================================
  Files           89       89              
  Lines         2427     2439      +12     
  Branches       314      299      -15     
===========================================
  Hits           756      756              
- Misses        1653     1665      +12     
  Partials        18       18              
Impacted Files Coverage Δ
TodoList.Web/Startup.cs 0.00% <0.00%> (ø)
...oList.Web/Views/Shared/_AdminActionsPartial.cshtml 0.00% <0.00%> (ø)
TodoList.Web/Views/Shared/_Layout.cshtml 0.00% <0.00%> (ø)
TodoList.Web/Views/Shared/_LoginPartial.cshtml 0.00% <0.00%> (ø)
TodoList.Web/Views/Todos/Create.cshtml 0.00% <0.00%> (ø)
TodoList.Web/Views/Todos/Delete.cshtml 0.00% <0.00%> (ø)
TodoList.Web/Views/Todos/Details.cshtml 0.00% <0.00%> (ø)
TodoList.Web/Views/Todos/Edit.cshtml 0.00% <0.00%> (ø)
TodoList.Web/Views/Todos/Home.cshtml 0.00% <0.00%> (ø)
TodoList.Web/Views/Todos/Index.cshtml 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a91a784...7c49e4c. Read the comment docs.

Copy link
Owner

@amoraitis amoraitis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Thank you!

@amoraitis amoraitis merged commit e197551 into amoraitis:develop Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants