Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Git as an explicit external command #33

Merged
merged 2 commits into from
Oct 24, 2023
Merged

use Git as an explicit external command #33

merged 2 commits into from
Oct 24, 2023

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Oct 23, 2023

as it's already done in list-repos-in-store with the external find command, to avoid conflict with built-ins, i propose to use ^git in the main module of nu-git-manager 😋

melMass
melMass approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@melMass melMass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me still think we should try to ensure that extended cli interfaces should still be compatible with the original one

@melMass melMass merged commit a37fdf1 into main Oct 24, 2023
3 checks passed
@amtoine amtoine deleted the git-as-external-call branch October 24, 2023 16:05
@amtoine
Copy link
Owner Author

amtoine commented Oct 24, 2023

This makes me still think we should try to ensure that extended cli interfaces should still be compatible with the original one

the only extended CLI interface we have are in sugar, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melMass melMass melMass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amtoine @melMass