Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #19

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Dev #19

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions charts/hypha/Chart.lock
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
dependencies:
- name: minio
repository: https://charts.min.io/
version: 3.3.0
repository: https://charts.bitnami.com/bitnami
version: 13.4.3
- name: tritoninferenceserver-hypha
repository: file://../tritoninferenceserver-hypha
version: 1.0.12
version: 1.0.13
- name: redis
repository: https://charts.bitnami.com/bitnami
version: 17.11.6
digest: sha256:b88fc0133e5328a56c6aef65d3867f212f95094704530dcc88cb0f03f10dbd55
generated: "2024-02-07T15:41:56.884037515Z"
digest: sha256:6db886f63b952120e9c3f63d986c30bda2c39b008562bae5d7b16743ce2b75b3
generated: "2024-02-08T08:55:56.380060859Z"
8 changes: 4 additions & 4 deletions charts/hypha/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,24 +13,24 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.16.14
version: 0.16.15
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: 0.15.35
dependencies:
- name: minio
version: 3.3.0
repository: https://charts.min.io/
version: 13.4.3
repository: https://charts.bitnami.com/bitnami
condition: minio.enabled
# - name: tritoninferenceserver
# repository: https://helm.ngc.nvidia.com/nvidia
# version: 1.0.0
# condition: tritoninferenceserver.enabled
- name: tritoninferenceserver-hypha
repository: "file://../tritoninferenceserver-hypha"
version: 1.0.12
version: 1.0.13
condition: tritoninferenceserver-hypha.enabled
- name: redis
repository: "https://charts.bitnami.com/bitnami"
Expand Down
Binary file added charts/hypha/charts/minio-13.4.3.tgz
Binary file not shown.
Binary file removed charts/hypha/charts/minio-3.3.0.tgz
Binary file not shown.
Binary file not shown.
Binary file not shown.
15 changes: 8 additions & 7 deletions charts/hypha/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ spec:
{{- include "hypha.selectorLabels" . | nindent 8 }}
spec:
nodeSelector:
{{ toYaml .Values.nodeSelector | indent 8 }}
{{ toYaml .Values.nodeSelector | nindent 8 }}
securityContext:
{{ toYaml .Values.securityContext | indent 8 }}
{{ toYaml .Values.securityContext | nindent 8 }}
containers:
- name: {{ .Chart.Name }}
command: ["/bin/sh", "-c"]
Expand All @@ -71,10 +71,10 @@ spec:
--triton-servers=http://{{(index .Values "tritoninferenceserver-hypha" "fullnameOverride")}}:{{(index .Values "tritoninferenceserver-hypha" "service" "port")}} \
{{- end }}
--enable-s3 \
--endpoint-url=http://{{ .Values.minio.fullnameOverride }}:{{.Values.minio.service.port}} \
--endpoint-url=http://{{ .Values.minio.fullnameOverride }}:{{.Values.minio.service.ports.api}} \
--endpoint-url-public={{ $S3_ENDPOINT_URL_PUBLIC }} \
--access-key-id="{{ .Values.minio.rootUser }}" \
--secret-access="{{ .Values.minio.rootPassword }}" \
--access-key-id="{{ .Values.minio.auth.rootUser }}" \
--secret-access="{{ .Values.minio.auth.rootPassword }}" \
--executable-path={{ .Values.executablePath }} \
--enable-server-apps \
--apps-dir={{ .Values.appsDir }} \
Expand All @@ -91,6 +91,8 @@ spec:
# --in-docker \
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
securityContext:
{{ toYaml .Values.securityContext | nindent 10 }}
env:
- name: AUTH0_AUDIENCE
value: "{{ $AUTH0_AUDIENCE }}"
Expand Down Expand Up @@ -126,8 +128,7 @@ spec:
protocol: TCP

securityContext:
# fsGroup: 1000
runAsUser: 0
{{ toYaml .Values.securityContext | nindent 8 }}



Expand Down
30 changes: 16 additions & 14 deletions charts/hypha/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,19 @@ auth0_domain: ""
jwt_secret: "xZ/aDcP+PfoTWgwA9ZADTtU/+djwMeMKz4QlSKRcgEs="
nodeSelector: {}
podLabels: {}
securityContext: {}
# TODO add when https://github.com/amun-ai/hypha/pull/588
# securityContext:
# enabled: true
# seLinuxOptions: null
# runAsUser: 1001
# runAsNonRoot: true
# privileged: false
# readOnlyRootFilesystem: false
# allowPrivilegeEscalation: false
# capabilities:
# drop: ["ALL"]
# seccompProfile:
# type: "RuntimeDefault"
# TODO
# Currently disabled in template because no obvious
# way to pass in the scripts to deployment
Expand Down Expand Up @@ -69,16 +81,6 @@ docker-registry:
minio:
fullnameOverride: "minio"
enabled: true
rootUser: "minio"
rootPassword: "minio123"
publicEndpointUrl: ""
browserRedirectUrl: ""

replicas: 4
ingress:
enabled: true
resources:
requests:
memory: 2Gi
persistence:
size: 1Gi
auth:
rootUser: "minio"
rootPassword: "minio123"
2 changes: 1 addition & 1 deletion charts/tritoninferenceserver-hypha/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.0.12
version: 1.0.13

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
17 changes: 9 additions & 8 deletions charts/tritoninferenceserver-hypha/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,15 @@ spec:
app: {{ template "tritoninferenceserver.name" . }}
release: {{ .Release.Name }}
{{- if .Values.podLabels }}
{{ toYaml .Values.podLabels | indent 8 }}
{{ toYaml .Values.podLabels | nindent 8 }}
{{- end }}
spec:
nodeSelector:
{{ toYaml .Values.nodeSelector | indent 8 }}
{{ toYaml .Values.nodeSelector | nindent 8 }}
securityContext:
{{ toYaml .Values.securityContext | indent 8 }}
# fsGroup: 1000
{{ toYaml .Values.securityContext | nindent 8 }}
initContainers:
{{ toYaml .Values.initContainers | indent 8 }}
{{ toYaml .Values.initContainers | nindent 8 }}
containers:
- name: tritoninferenceserver
image: {{ .Values.image.imageName }}
Expand All @@ -40,8 +39,10 @@ spec:
value: "{{ .Values.image.modelSnapshots }}"
- name: TF_FORCE_GPU_ALLOW_GROWTH
value: "true"
{{ toYaml .Values.image.env | indent 12 }}
{{ toYaml .Values.image.env | nindent 12 }}
imagePullPolicy: IfNotPresent
securityContext:
{{ toYaml .Values.securityContext | nindent 12 }}
readinessProbe:
{{- toYaml .Values.readinessProbe | nindent 12 }}
httpGet:
Expand All @@ -53,12 +54,12 @@ spec:
path: /v2/health/live
port: 8000
resources:
{{ toYaml .Values.resources | indent 12 }}
{{ toYaml .Values.resources | nindent 12 }}
command: ["/bin/sh"]
args:
- -c
- >-
chmod 1777 /tmp && apt-get update && apt-get install -y libstdc++6 libgl1-mesa-glx && tritonserver --model-store={{ .Values.image.modelStore }} --log-verbose=1 --model-control-mode=poll --strict-readiness=false --repository-poll-secs=60 --exit-on-error=false --strict-model-config=false --model-repository={{ .Values.image.modelRepository}}
tritonserver --model-store={{ .Values.image.modelStore }} --log-verbose=1 --model-control-mode=poll --strict-readiness=false --repository-poll-secs=60 --exit-on-error=false --strict-model-config=false --model-repository={{ .Values.image.modelRepository}}
ports:
- containerPort: 8000
name: http
Expand Down
16 changes: 13 additions & 3 deletions charts/tritoninferenceserver-hypha/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,9 @@ ingress:

resources:
requests:
nvidia.com/gpu: 0
memory: "2Gi"
cpu: "1"
limits:
nvidia.com/gpu: 0
memory: "3Gi"
cpu: "1"

Expand All @@ -54,7 +52,19 @@ autoscaling:

nodeSelector: {}
podLabels: {}
securityContext: {}
securityContext:
enabled: true
seLinuxOptions: null
runAsUser: 1001
runAsNonRoot: true
privileged: false
readOnlyRootFilesystem: false
allowPrivilegeEscalation: false
capabilities:
drop: ["ALL"]
seccompProfile:
type: "RuntimeDefault"


readinessProbe:
httpGet:
Expand Down
Loading