Fix removing workspace

amun-ai · Dec 18, 2024 · 0710007 · 0710007
1 parent 039059c
commit 0710007
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/hypha/VERSION b/hypha/VERSION
@@ -1,3 +1,3 @@
 {
-    "version": "0.20.44.post4"
+    "version": "0.20.44.post5"
 }
diff --git a/hypha/core/store.py b/hypha/core/store.py
@@ -323,7 +323,7 @@ async def housekeeping(self):
                             f"Removed {len(summary['removed_clients'])} clients from workspace {workspace.id}"
                         )
                 except Exception as e:
-                    logger.exception(f"Error in housekeeping {workspace}: {e}")
+                    logger.exception(f"Error in housekeeping {workspace.id}: {e}")
 
     async def upgrade(self):
         """Upgrade the store."""

diff --git a/hypha/core/workspace.py b/hypha/core/workspace.py
@@ -1890,9 +1890,10 @@ async def cleanup(
         # list all the clients and ping them
         # If they are not responding, delete them
         client_keys = await self._list_client_keys(workspace)
-        if len(client_keys) <= 0:
+        if len(client_keys) <= 0 and not workspace_info.persistent:
             await self.delete_workspace(workspace_info.id, context=context)
             return {"removed_workspace": workspace_info.id, "removed_clients": []}
+
         removed = []
         summary = {}
         if not workspace_info.persistent: