First pass at converting test -> tests sections, some outputs conversion work
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Starts work on transforming the old to the new test section format - Most transformations appear to be simple relocations - Breaks unit tests, they'll need to be updated later
- Maps the old test section values to their new equivalents - Includes some minor refactoring of repeated work with new convenience functions - Modifies unit tests
schuylermartin45
requested review from
beeankha and
JeanChristopheMorinPerso
Upon further reflection, the comment recovery system won't be very useful. This commit simplifies some logic and now comments that have been dropped are logged as WARNINGS only.
- This starts some (but I don't think all) of the conversions required for the `outputs` section - This was easier than I expected, so I'm going to add it to the existing PR
schuylermartin45
changed the title
test -> tests sectionstest -> tests sections, some outputs conversion work
beeankha
approved these changes
Feb 26, 2024
schuylermartin45
deleted the
smartin_starting_test_section_transforms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the badly-hand-drawn diagram above for a rough outline of what is being done ^
This is the first-pass at converting the old
testrecipe section to the newtestsrecipe section. Alltestsections should be converted, regardless if the recipe produces single or multiple outputs.Most keys map directly to newer counter parts. If a
pip checkcommand is listed undercommands, it is upgraded to the newtests/python/pip-checkflag. If it not found, the flag is set tofalse.For now, only exact matches for
- pip checkare converted, with no special logic for handling selectors. This should cover the vast majority of recipes (at least fromAnacondaRecipes).The top-level keys found in the
testssection are then canonically sorted, based on the ordering found in CEP-14.Unit tests have been modified as needed.
EDIT: I was working on some of the
outputsconversion work and it looked pretty straight forward, so I've added some of that into this PR.