Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD9434: Zed porting and documentation #1210

Merged
merged 14 commits into from
Dec 7, 2023
Merged

Conversation

cristianmihaipopa
Copy link
Collaborator

@cristianmihaipopa cristianmihaipopa commented Nov 3, 2023

PR Description

Created a porting project for AD9434 and Zedboard(new files: projects/ad9434_fmc/zed). Also, added documentation for AD9434, specifically the HDL documentation, and updated the WIKI page. Also, added the documentation for AD719x.
Added the .dts file too: analogdevicesinc/linux#2350
Additionally updated the wiki page: https://wiki.analog.com/resources/fpga/xilinx/fmc/ad9434?force_rev=1

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@gastmaier
Copy link
Contributor

Hi, can you rebase it with main? Or cherry-pick only your commits.

@gastmaier gastmaier self-requested a review November 3, 2023 15:53
@cristianmihaipopa cristianmihaipopa force-pushed the ad9434_zed_port branch 2 times, most recently from 842304e to 2f15ffd Compare November 7, 2023 13:34
Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review related to the documentation only.

docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
gastmaier
gastmaier previously approved these changes Nov 10, 2023
Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation is OK.
The HDL needs to be reviewed.

docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
projects/ad9434_fmc/zed/system_constr.xdc Outdated Show resolved Hide resolved
projects/ad9434_fmc/zed/system_project.tcl Show resolved Hide resolved
projects/ad9434_fmc/zed/system_top.v Outdated Show resolved Hide resolved
projects/ad9434_fmc/zed/system_top.v Outdated Show resolved Hide resolved
projects/ad9434_fmc/zed/system_top.v Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
gastmaier
gastmaier previously approved these changes Nov 24, 2023
Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to squash.

-Added to the toctree this project

-Later: fixed rebase conflict

Signed-off-by: Cristian Mihai Popa <[email protected]>
…f the doc.

-Later: Fixed rebase conflicts

Signed-off-by: Cristian Mihai Popa <[email protected]>
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9434_fmc/index.rst Outdated Show resolved Hide resolved
@cristianmihaipopa cristianmihaipopa changed the title AD9434: Zed porting and documentation, ad719x documentation AD9434: Zed porting and documentation Nov 29, 2023
@cristianmihaipopa cristianmihaipopa merged commit c1e0698 into main Dec 7, 2023
1 of 2 checks passed
@cristianmihaipopa cristianmihaipopa deleted the ad9434_zed_port branch December 7, 2023 13:19
bia1708 pushed a commit to bia1708/hdl that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants