Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ad7606x: Fix serial bug #1348

Merged
merged 1 commit into from
Jun 21, 2024
Merged

ad7606x: Fix serial bug #1348

merged 1 commit into from
Jun 21, 2024
+1 −1

Conversation

StancaPop
Copy link
Contributor

PR Description

Fix the issue that caused a bug in the serial configuration build.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • [x ] I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@StancaPop StancaPop requested a review from sarpadi as a code owner June 7, 2024 09:14
@StancaPop StancaPop requested review from SRaus and bia1708 June 7, 2024 09:15
gastmaier
gastmaier approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug due to #1206 merged to main after #1251.
PRs should always be tested rebased onto main before merging.

@sarpadi
Copy link
Contributor

sarpadi commented Jun 14, 2024 •
edited
Loading

Please make another PR to merge the same branch into the next_stable branch. This update is needed there as well

@sarpadi sarpadi merged commit 9258bbd into main Jun 21, 2024
1 of 4 checks passed
@StancaPop StancaPop deleted the fix_ad7606x_serial branch June 21, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastmaier gastmaier gastmaier approved these changes

@sarpadi sarpadi sarpadi approved these changes

@SRaus SRaus SRaus approved these changes

@bia1708 bia1708 bia1708 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StancaPop @sarpadi @gastmaier @SRaus @bia1708