Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete projects and add their documentation #1558

Merged
merged 11 commits into from
Jan 23, 2025

Conversation

IuliaCMoldovan
Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan commented Jan 17, 2025

PR Description

Removed obsolete projects:

  • AD9739A-FMC
  • FMCADC2
  • FMCADC5
  • FMCJESDADC1

Added documentation for FMCADC2, FMCADC5 and FMCJESDADC1.
Updated the documentation for AD9739A-FMC to state that it is obsolete.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@cristianmihaipopa
Copy link
Collaborator

I checked the changes, and everything seems good to me, but one thing should be addressed regarding the last release for each of the obsolete project (present in projects/index). Do we route to the last presence of the project on our branches or to the last presence of the project in the Kuiper release? For example:

The last thing that must be done is updating the Wiki pages if needed and making sure after this PR is approved that the links from their respective Wiki page redirect the user to the new Github page.

@IuliaCMoldovan
Copy link
Contributor Author

Good observation. In my opinion, it should correspond to the last Kuiper release. I will check which is the last Kuiper release for each project and let you know.

@IuliaCMoldovan IuliaCMoldovan changed the title Remove obsolete IPs & projects and add their documentation Remove obsolete projects and add their documentation Jan 20, 2025
@cristianmihaipopa
Copy link
Collaborator

Everything looks good to me!😄

docs/projects/index.rst Show resolved Hide resolved
@IuliaCMoldovan IuliaCMoldovan merged commit 37178af into main Jan 23, 2025
3 of 5 checks passed
@IuliaCMoldovan IuliaCMoldovan deleted the remove_obsolete branch January 23, 2025 13:18
nunojsa added a commit to analogdevicesinc/meta-adi that referenced this pull request Jan 24, 2025
The following projects were removed from the hdl tree [1]. Therefore it
makes no sense to maintain them in meta-adi.

[1]: analogdevicesinc/hdl#1558
Signed-off-by: Nuno Sa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants