Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD2S1210 updates for RPi #2311

Merged
merged 1 commit into from
Nov 2, 2023
Merged

AD2S1210 updates for RPi #2311

merged 1 commit into from
Nov 2, 2023

Conversation

dlech
Copy link
Collaborator

@dlech dlech commented Oct 30, 2023

This is essentially the same PR as #2261 except targeting the RPi 6.1 branch.

All of the commits are the same except the last one which is a RPi device tree overlay instead of the ZedBoard device tree.

@dlech dlech requested a review from nunojsa October 30, 2023 18:03
@nunojsa
Copy link
Collaborator

nunojsa commented Oct 31, 2023

@dlech,

Please drop all the patches and just leave the overlay one. As soon as we merge #2261 into master, we have a CI job that will automatically cherry-pick all the patches into 6.1 and the rebeased adi-6.1.

This adds a device tree overlay for the AD2S1210 resolver to digital
converter.

Signed-off-by: David Lechner <[email protected]>
@dlech dlech force-pushed the dlech/adi-rpi-6.1.y/ad2s1210 branch from e58c88d to a343c43 Compare October 31, 2023 14:37
@dlech
Copy link
Collaborator Author

dlech commented Oct 31, 2023

Done. Just the overlay patch is left now.

Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to drop the fragment syntax and reference nodes directly instead?

@dlech
Copy link
Collaborator Author

dlech commented Oct 31, 2023

I don't think we can do that for all nodes because of the fixed-mode dtparam which uses fragment numbers.

@nunojsa nunojsa merged commit ff14a76 into rpi-6.1.y Nov 2, 2023
3 checks passed
@nunojsa nunojsa deleted the dlech/adi-rpi-6.1.y/ad2s1210 branch November 2, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants