projects:ad405x_iio: Resolve build warnings #127
+24
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Shetty-Anush
commented
Feb 3, 2025
Shetty-Anush
commented
- Update the application files acccording to the Coverity report
- Add ad4050 as a device and double the value of data in test scripts
- Add delay before eeprom read
1. Update the application files acccording to the Coverity report 2. Add ad4050 as a device and double the value of data in test scripts 3. Add delay before eeprom read Signed-off-by: Anush Shetty <[email protected]>
Shetty-Anush
requested review from
SaikiranGudla,
jansunil,
D-Disha and
gprasadbng
as code owners
D-Disha
approved these changes
Feb 3, 2025
| @@ -41,7 +42,8 @@ def test_ad405x(serial_port, device_name, target_reset): | |||
|
|
|||
| # Extract the data of enabled channels in rx_enabled_channels | |||
| for sample_index in range(0, len(data)): | |||
| data[sample_index] = chn_data[ad405x_dev.rx_enabled_channels[0]] | |||
| # The eval board reports have of the actual input voltage | |||
There was a problem hiding this comment.
Is this?
Suggested change
| # The eval board reports have of the actual input voltage | |
| # The eval board reports half of the actual input voltage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.