Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ad719x.py #342

Closed
wants to merge 2 commits into from
Closed

Added ad719x.py #342

wants to merge 2 commits into from

Conversation

pmallick-adi
Copy link
Contributor

@pmallick-adi pmallick-adi commented Jun 28, 2022

Added a test script - test_ad719x.py
Added an example code - ad719x_example.py
Updated index.rst
Updated init.py
Updated supported_parts.md
Added adi.ad719x.rst

Signed-off-by: Pratyush Mallick [email protected]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware:
  • OS:

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pmallick-adi
Copy link
Contributor Author

@tfcollins This is ready for review.

@pmallick-adi
Copy link
Contributor Author

Hi @tfcollins,
Do these changes look good to you?

@tfcollins
Copy link
Collaborator

Please rebase from master and re-check the lint errors.

O... and please make sure to add me as a reviewer to the PRs in the future. That way I get notified of changes and stuff.

@tfcollins
Copy link
Collaborator

@pmallick-adi Would doing things this way make sense: #350

@pmallick-adi
Copy link
Contributor Author

@pmallick-adi Would doing things this way make sense: #350

Hi @tfcollins,

This seems to be a better way to create classes for different ADCs. Do you plan to remove most of the adxxx.py files and leverage the adc_shared.py file? Do you want me updated the PR accordingly?

Added a test script - test_ad719x.py
Added an example code - ad719x_example.py
Updated index.rst
Updated init.py
Updated supported_parts.md
Added adi.ad719x.rst

Signed-off-by: Pratyush Mallick <[email protected]>
@tfcollins tfcollins self-requested a review July 18, 2022 14:44
@tfcollins
Copy link
Collaborator

@pmallick-adi lets merge this in first. I can do the cleanup for the adc_shared class after.

Can you rebase and I'll merge this in

-Travis

@pmallick-adi
Copy link
Contributor Author

@pmallick-adi lets merge this in first. I can do the cleanup for the adc_shared class after.

Can you rebase and I'll merge this in

-Travis

Hi Travis,

I have created a new PR as there were some merge conflicts. #353
We can close this PR.

Regards,
Pratyush

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants