Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AD5780, AD5781, AD5790, AD5791, AD5760 #452

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

SaikiranGudla
Copy link
Contributor

Add ad578x.py
Add a test script - test_ad578x.py
Add an example code - ad578x_example.py
Update index.rst
Update init.py
Update supported_parts.md
Add adi.ad578x.rst

@SaikiranGudla
Copy link
Contributor Author

May I know if there are any comments on the PR, @tfcollins ?

@tfcollins tfcollins self-requested a review July 11, 2023 15:22
tasks.py Outdated
@@ -224,6 +225,7 @@ def checkemulation(c):
"ad4630",
"ad5627",
"ad5686",
"ad578x",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only allow skipping of context file checking under specific circumstances. Can you not include the context file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok without that skip you need to generate a context file: https://analogdevicesinc.github.io/pyadi-iio/dev/index.html#new-hardware-requirements

@SaikiranGudla SaikiranGudla force-pushed the master branch 2 times, most recently from ef8ec7d to 05e8733 Compare July 18, 2023 09:11
@SaikiranGudla SaikiranGudla force-pushed the master branch 2 times, most recently from b597c32 to 2b22d95 Compare September 14, 2023 11:48
Add ad578x.py
Add a test script - test_ad578x.py
Add an example code - ad578x_example.py
Update index.rst
Update init.py
Update supported_parts.md
Add adi.ad578x.rst

Signed-off-by: SGudla <[email protected]>
@SaikiranGudla
Copy link
Contributor Author

May I know if there are any other review comments, @tfcollins?

@tfcollins tfcollins self-requested a review October 27, 2023 22:40
@tfcollins tfcollins merged commit 505bcbf into analogdevicesinc:master Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants