gui: rename and move some widgets from gr-util #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IonutMuthi
reviewed
Mar 22, 2024
| void TimeYAutoscale::addChannels(PlotChannel *c) { m_channels.append(c); } | ||
| void PlotAutoscaler::addChannels(PlotChannel *c) { m_channels.append(c); } | ||
|
|
||
| void PlotAutoscaler::removeChannels(PlotChannel *c) { m_channels.removeAll(c); } |
There was a problem hiding this comment.
Why do we need to use removeAll ? removeOne dose the same thing
is there a case where we would have multiple of the same channel ? if so do we want to remove all of them at once ?
There was a problem hiding this comment.
Yes, it makes no sense to have duplicates in the autoscaler .. So remove them all in case you have them ..
IonutMuthi
reviewed
Mar 22, 2024
|
|
||
| m_min = new PositionSpinButton( | ||
| { | ||
| {"V", 1e0}, |
There was a problem hiding this comment.
I think the unit of measure should be a variable not all axis will plot Volts
There was a problem hiding this comment.
The menuplotaxisrangecontrol will get it's unit from plotaxis on construction.
Although it should be possible to change the unit at runtime, a refactor of spinbox is required.
IonutMuthi
reviewed
Mar 22, 2024
TimeYAutoscale -> PlotAutoscaler TimeYControl -> MenuPlotAxisRangeControl created class MenuPlotChannelCurveStyleControl Signed-off-by: Adrian Suciu <[email protected]>
…trol Signed-off-by: Adrian Suciu <[email protected]>
adisuciu
force-pushed
the
dev_movewidgetstogui
branch
from
a3774b4 to
9f1e960
Compare
IonutMuthi
approved these changes
Mar 22, 2024
Signed-off-by: Adrian Suciu <[email protected]>
andrei47w
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimeYAutoscale -> PlotAutoscaler
TimeYControl -> MenuPlotAxisRangeControl
created class MenuPlotChannelCurveStyleControl