SWIOT Ad tool refactoring #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreidanila1
requested review from
adisuciu,
Andrei-Fabian-Pop and
AlexandraTrifan
| .constDataOptions = "[0 1 8191]"}, | ||
| this); | ||
| QLayoutItem *item = dacCode->getUiStrategy()->ui()->layout()->itemAt(0); | ||
| PositionSpinButton *dacSpin = nullptr; |
There was a problem hiding this comment.
we need to check whether IIO Widgets display measurement units where needed (line edits/spinbtns/etc)
|
We still need to handle plot scales - displaying the unit value / division to the user for all enabled channels (such that it doesn't need to select each channel to check its value in comparison with the other channels). Place these in a measurement container (similar to the time plugin). |
andreidanila1
force-pushed
the
dev_swiot_refactor_plugin
branch
from
e60f6a6 to
57023b7
Compare
andreidanila1
force-pushed
the
dev_swiot_refactor_ad
branch
from
9bf28ae to
68a1813
Compare
Signed-off-by: andrei.danila <[email protected]>
Signed-off-by: andrei.danila <[email protected]>
Signed-off-by: andrei.danila <[email protected]>
andreidanila1
force-pushed
the
dev_swiot_refactor_ad
branch
from
5c473cc to
98dff77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes: