mldistwatch: fix logging for uninteresting files #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rspier
approved these changes
May 5, 2024
First, "1" is not a reason. Return a string. Secondly, do not log this string by default. It is boring. This is substandard work, but further work will just complicate the PAUSE::Indexer::Context work, which will make fixing this in a really nice way easy!
rjbs
force-pushed
the
mldistwatch-log-even-less
branch
from
a7bcdc2 to
caef886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, "1" is not a reason. Return a string.
Secondly, do not log this string by default. It is boring.
This is substandard work, but further work will just complicate the PAUSE::Indexer::Context work, which will make fixing this in a really nice way easy!
This is an alternative to #498