remove superflous todo #157
andreabediniAnnotations
1 error and 4 warnings
|
hlint
HLint failed with status: 1. Warning (1), Suggestion (3)
|
|
hlint:
Cabal-syntax/src/Distribution/Fields/Parser.hs#L371
Suggestion in sectionLayoutOrBraces in module Distribution.Fields.Parser: Move brackets to avoid $ ▫︎ Found: "(trace \"braces\"\n $ do openBrace\n void $ many (tokWhitespace <|> tokComment)\n elems <- elements zeroIndentLevel\n optional tokIndent\n closeBrace\n return elems)\n <|> (trace \"elements\" $ elements ilevel)" ▫︎ Perhaps: "(trace \"braces\"\n $ do openBrace\n void $ many (tokWhitespace <|> tokComment)\n elems <- elements zeroIndentLevel\n optional tokIndent\n closeBrace\n return elems)\n <|> trace \"elements\" (elements ilevel)"
|
|
hlint:
Cabal-syntax/src/Distribution/Fields/Parser.hs#L371
Suggestion in sectionLayoutOrBraces in module Distribution.Fields.Parser: Move brackets to avoid $ ▫︎ Found: "(trace \"braces\"\n $ do openBrace\n void $ many (tokWhitespace <|> tokComment)\n elems <- elements zeroIndentLevel\n optional tokIndent\n closeBrace\n return elems)\n <|> (trace \"elements\" $ elements ilevel)" ▫︎ Perhaps: "trace\n \"braces\"\n (do openBrace\n void $ many (tokWhitespace <|> tokComment)\n elems <- elements zeroIndentLevel\n optional tokIndent\n closeBrace\n return elems)\n <|> (trace \"elements\" $ elements ilevel)"
|
|
hlint:
Cabal-syntax/src/Distribution/PackageDescription/ExactPrint.hs#L55
Suggestion in foldExactly in module Distribution.PackageDescription.ExactPrint: Move brackets to avoid $ ▫︎ Found: "(ExactMeta <$> commentsToMeta meta')\n <>\n (fmap ExactPretty\n $ attachPositions [] (exactPositions meta') pretty)" ▫︎ Perhaps: "(ExactMeta <$> commentsToMeta meta')\n <>\n fmap ExactPretty (attachPositions [] (exactPositions meta') pretty)"
|
|
hlint:
Cabal-syntax/src/Distribution/PackageDescription/ExactPrint.hs#L177
Warning in sortFields in module Distribution.PackageDescription.ExactPrint: Avoid reverse ▫︎ Found: "reverse . sortOn (exactFieldPosition)" ▫︎ Perhaps: "sortOn (Data.Ord.Down . exactFieldPosition)" ▫︎ Note: Stabilizes sort order
|