Set preconditions for artifact signing #500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the signing task is only started if the required environment properties are set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where publishing BigBone to a local Maven repository failed because no signing configuration was present. Usually the error appeared when you tried to run one of these Gradle tasks:
./gradlew publishBigbonePublicationToMavenLocal./gradlew publishBigbonePublicationToLocalBuildRepoRepositoryAs we do not need signing for local publications, we can safely turn this off using the changes proposed.
Type of Change
Breaking Changes
None.
How Has This Been Tested?
I ran
./gradlew publishBigbonePublicationToMavenLocaland./gradlew publishBigbonePublicationToLocalBuildRepoRepository. Also the Github build works as expected.Mandatory Checklist
gradle checkand there were no errors reported