stop Gson exposure by making MastodonClient.getSerializer internal #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #51.
There are some weird things going on that I want to mention here:
MockClient
for bigbone-rx. This might be a sign of either a badly designed test, or other structural issues.Neither is really great, but we shouldn't keep
MastodonClient.getSerializer()
public only to keep tests and outdated samples working.I also had to use
@PublishedApi
on the now internal function. That means that the function is "technically exposed in bytecode" but not able to be called directly from outside the module. I assume this is OK.