Undo changes of #20 in favor of #25

andresz1 · Jun 21, 2020 · d8dfd12 · d8dfd12
1 parent 0203845
commit d8dfd12
Show file tree

Hide file tree

Showing 4 changed files with 60 additions and 78 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -13,10 +13,6 @@
       "jest/globals": true
     },
     "rules": {
-      "no-console": "off",
-      "no-unused-vars": "off",
-      "@typescript-eslint/no-unused-vars": [
-        "error"
-      ]
+      "no-console": "off"
     }
   }
diff --git a/action.yml b/action.yml
@@ -14,10 +14,6 @@ inputs:
   skip_step:
     required: false
     description: 'which step to skip, either "install" or "build"'
-  update_review:
-    required: false
-    description: "will update the previous review if the status hasn't changed"
-    default: false
 runs:
   using: 'node12'
   main: 'dist/index.js'
diff --git a/src/SizeLimit.spec.ts b/src/SizeLimit.spec.ts
@@ -95,4 +95,52 @@ describe("SizeLimit", () => {
       ["dist/index.js", "98.53 KB (-9.92% 🔽)"]
     ]);
   });
+
+  test("should format size-limit with new section", () => {
+    const limit = new SizeLimit();
+    const base = {
+      "dist/index.js": {
+        name: "dist/index.js",
+        size: 110894
+      }
+    };
+    const current = {
+      "dist/index.js": {
+        name: "dist/index.js",
+        size: 100894
+      },
+      "dist/new.js": {
+        name: "dist/new.js",
+        size: 100894
+      }
+    };
+
+    expect(limit.formatResults(base, current)).toEqual([
+      SizeLimit.SIZE_RESULTS_HEADER,
+      ["dist/index.js", "98.53 KB (-9.92% 🔽)"],
+      ["dist/new.js", "98.53 KB (+100% 🔺)"]
+    ]);
+  });
+
+  test("should format size-limit with deleted section", () => {
+    const limit = new SizeLimit();
+    const base = {
+      "dist/index.js": {
+        name: "dist/index.js",
+        size: 110894
+      }
+    };
+    const current = {
+      "dist/new.js": {
+        name: "dist/new.js",
+        size: 100894
+      }
+    };
+
+    expect(limit.formatResults(base, current)).toEqual([
+      SizeLimit.SIZE_RESULTS_HEADER,
+      ["dist/index.js", "0 B (-100%)"],
+      ["dist/new.js", "98.53 KB (+100% 🔺)"]
+    ]);
+  });
 });
diff --git a/src/main.ts b/src/main.ts
@@ -1,42 +1,11 @@
-import { GitHub, context } from "@actions/github";
 import { getInput, setFailed } from "@actions/core";
-
-import { Octokit } from "@octokit/rest";
-import SizeLimit from "./SizeLimit";
-import Term from "./Term";
+import { context, GitHub } from "@actions/github";
 // @ts-ignore
 import table from "markdown-table";
+import Term from "./Term";
+import SizeLimit from "./SizeLimit";
 
 const SIZE_LIMIT_URL = "https://github.com/ai/size-limit";
-const SIZE_LIMIT_HEADING = `## [size-limit](${SIZE_LIMIT_URL}) report`;
-
-const stateToEventMapping: { [key: string]: any } = {
-  COMMENTED: "COMMENT",
-  CHANGES_REQUESTED: "REQUEST_CHANGES"
-};
-
-async function fetchPreviousReview(
-  octokit: GitHub,
-  repo: { owner: string; repo: string },
-  pr: { number: number }
-) {
-  const reviews: Octokit.PullsListReviewsResponse = await octokit.paginate(
-    // TODO: replace with octokit.pulls.listReviews when upgraded to v17
-    "GET /repos/:owner/:repo/pulls/:pull_number/reviews",
-    {
-      ...repo,
-      // eslint-disable-next-line camelcase
-      pull_number: pr.number
-    }
-  );
-
-  const sizeLimitReviews = reviews.filter(review =>
-    review.body.startsWith(SIZE_LIMIT_HEADING)
-  );
-  return sizeLimitReviews.length > 0
-    ? sizeLimitReviews[sizeLimitReviews.length - 1]
-    : null;
-}
 
 async function run() {
   try {
@@ -50,7 +19,6 @@ async function run() {
     }
 
     const token = getInput("github_token");
-    const updateReview = getInput("updateReview");
     const skipStep = getInput("skip_step");
     const buildScript = getInput("build_script");
     const octokit = new GitHub(token);
@@ -83,44 +51,18 @@ async function run() {
 
     const event = status > 0 ? "REQUEST_CHANGES" : "COMMENT";
     const body = [
-      SIZE_LIMIT_HEADING,
+      `## [size-limit](${SIZE_LIMIT_URL}) report`,
       table(limit.formatResults(base, current))
     ].join("\r\n");
 
-    let previousReview: Octokit.PullsListReviewsResponseItem | null = null;
-    let isReviewStateChanged = true;
-    try {
-      previousReview = await fetchPreviousReview(octokit, repo, pr);
-      isReviewStateChanged =
-        !previousReview || stateToEventMapping[previousReview.state] !== event;
-
-      if (!isReviewStateChanged && previousReview.body === body) {
-        // The last review was the exact same, so we shouldn't repeat
-        return;
-      }
-    } catch (error) {
-      console.log("Failed to compare against previous reviews");
-    }
-
     try {
-      if (updateReview && !isReviewStateChanged) {
-        await octokit.pulls.updateReview({
-          ...repo,
-          // eslint-disable-next-line camelcase
-          pull_number: pr.number,
-          // eslint-disable-next-line camelcase
-          review_id: previousReview.id,
-          body
-        });
-      } else {
-        await octokit.pulls.createReview({
-          ...repo,
-          // eslint-disable-next-line camelcase
-          pull_number: pr.number,
-          event,
-          body
-        });
-      }
+      octokit.pulls.createReview({
+        ...repo,
+        // eslint-disable-next-line camelcase
+        pull_number: pr.number,
+        event,
+        body
+      });
     } catch (error) {
       console.log(
         "Error creating PR review. This can happen for PR's originating from a fork without write permissions."