Skip to content

Commit

Permalink
resolve_message_name_conflict_with_field_name is now a Shadow case
Browse files Browse the repository at this point in the history
we change the test as this is not a proper case
  • Loading branch information
tardyp committed Sep 2, 2024
1 parent 789ca4b commit 293acbb
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions prost-reflect/src/descriptor/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,8 @@ fn resolve_message_name_conflict_with_field_name() {
}],
};

let descriptor_pool = DescriptorPool::from_file_descriptor_set(file_descriptor_set).unwrap();
let message = descriptor_pool
.get_message_by_name("my.package.MyMessage")
.unwrap();
let field = message.get_field_by_name("MyMessage").unwrap();
assert_eq!(
field.kind().as_message().unwrap().full_name(),
"my.package.MyMessage"
);
let e = DescriptorPool::from_file_descriptor_set(file_descriptor_set).unwrap_err();
assert_eq!(e.to_string(), "name 'MyMessage' is shadowed");
}

#[test]
Expand Down

0 comments on commit 293acbb

Please sign in to comment.