Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolution of field type when it is the same as the field name #100

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

andrewhickman
Copy link
Owner

Fixes #99

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 76.65%. Comparing base (d554c53) to head (c25b777).

Files Patch % Lines
prost-reflect/src/descriptor/build/mod.rs 82.27% 14 Missing ⚠️
prost-reflect/src/descriptor/build/resolve.rs 83.33% 7 Missing ⚠️
prost-reflect/src/descriptor/build/options.rs 80.00% 3 Missing ⚠️
prost-reflect/src/dynamic/serde/ser/mod.rs 0.00% 2 Missing ⚠️
prost-reflect/src/dynamic/fields.rs 50.00% 1 Missing ⚠️
prost-reflect/src/dynamic/text_format/format.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   76.30%   76.65%   +0.34%     
==========================================
  Files          31       31              
  Lines        5452     5439      -13     
==========================================
+ Hits         4160     4169       +9     
+ Misses       1292     1270      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewhickman andrewhickman merged commit 5c22645 into main Apr 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in Type Resolve Logic
1 participant