Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore type name domain when deserializing Any #145

Merged
merged 3 commits into from
Mar 1, 2025

Conversation

damszew
Copy link
Contributor

@damszew damszew commented Mar 1, 2025

This PR changes how type url is parsed. Now it completely ignores anything before last '/' as specified by Any docs and to be more in-line with default prost behaviour.

Closes #144

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.76%. Comparing base (74042cc) to head (832ab0d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
prost-reflect/src/dynamic/serde/de/wkt.rs 75.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   79.72%   79.76%   +0.03%     
==========================================
  Files          31       31              
  Lines        5258     5257       -1     
==========================================
+ Hits         4192     4193       +1     
+ Misses       1066     1064       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewhickman andrewhickman merged commit 18438d9 into andrewhickman:main Mar 1, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to DynamicMessage::decode type Any created by prost
2 participants