Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Update Views-Hilt Project to API Level 34 with Gradle 8.4 #1003

Open
wants to merge 1 commit into
base: views-hilt
Choose a base branch
from

Conversation

mrlonewolfer
Copy link


Description

This pull request updates the Views-Hilt project to API level 34 and uses Gradle version 8.4. The changes include updates to the AndroidManifest, build.gradle files, and some Kotlin code.

Changes

  • Updated AndroidManifest.xml to add android:exported="true" attribute to the TasksActivity declaration.
  • Updated TasksViewModel.kt to replace Transformations.map with map extension function.
  • Updated build.gradle files to use newer versions of dependencies, including Kotlin, Navigation, Hilt, and other libraries.
  • Added multiDexEnabled true in the defaultConfig block of the app-level build.gradle to enable multidex support.
  • Updated TodoApplication.kt to import BuildConfig from androidx.multidex package.
  • Updated Event.kt to fix the method signature for onChanged to match the interface.
  • Updated HiltExt.kt to use R.style.AppTheme instead of R.style.FragmentScenarioEmptyFragmentActivityTheme for themeResId parameter.

Purpose

This PR aims to update the Views-Hilt project to support API level 34 and use the latest version of Gradle, enabling compatibility with newer Android features and libraries. It resolves build errors and ensures the project can be built and run successfully.

Notes

Without this PR, the Views-Hilt project is not able to build and run due to compatibility issues with API level 34 and Gradle 8.4. This PR resolves those issues and ensures the project can be built and run smoothly.


@small-dream
Copy link

small-dream commented Oct 1, 2024 via email

@abooodabdlaa
Copy link

تم

@small-dream
Copy link

small-dream commented Oct 25, 2024 via email

Copy link

@abooodabdlaa abooodabdlaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

نعم

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants