Add latency features to extensions #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update all dep versions to latest - update gradle to 8.11 - update corutines and kotlin versions to latest
- update versions to latest Test: n/a
- UI to show the processing progress indicator - this will animate the progress on each progress update - UI to show the postview Test: manually tested using S24
- if the device supports process indicator then show process indicator - if the device supports postview then show the postview Test: manually tested using S24
- add a hold still text - add a background for the progress and hold still text - make sure the spinner animates to 100 before switching out postview for final capture Test: manual testing on pixel 8
- show the postview - show the final capture on top
- reset the progress indicator to 0 before it gets displayed again
- if the device does not support processing indicator then the indicator still appears - this fixes the issue
donovanfm
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.