feature(network): introducing Ktor interceptor #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
srtvprateek
commented
Sep 12, 2023
srtvprateek
commented
- Ktor interceptor introduced
- Custom interceptor exposed
github-actions
bot
added
network
logger
exceptions
core
sample
rooms-database
shared-preferences
labels
* feat: ktor interceptor * address review comments * ktlint * address review comments * Update build.gradle --------- Co-authored-by: Prateek <[email protected]>
* refactor & fixes * refactor * removed need to add base module as dependency * code restructure * refactor * refactor * move CacheDirectoryProvider to okhttp module * PlutoInterceptor refactored * refactor * PlutoKtorInterceptor refactored * access modifier fixed * gradle fixes * access modifier fixed * mock setting in ktor interceptor * refactor * publish config fixes * removed old custom interceptor logic * data field cleanup * init * content type fix * query param incorrect data fix * sample code refactor * fix(pluto): missing no-op methods added (#271) * fix(pluto): missing no-op methods added * pending fix * added core no-op * renaming
srtvprateek
force-pushed
the
network_ktor
branch
from
f8423b1
to
54b0d87
Compare
epicadk
approved these changes
Sep 13, 2023
...plugins/network/core/lib-no-op/src/main/java/com/pluto/plugins/network/PlutoNetworkPlugin.kt
Outdated
Show resolved
Hide resolved
| @@ -24,8 +24,9 @@ import com.pluto.utilities.share.Shareable | |||
| import com.pluto.utilities.share.lazyContentSharer | |||
| import com.pluto.utilities.spannable.setSpan | |||
| import com.pluto.utilities.viewBinding | |||
| import io.ktor.http.Url | |||
|
|
|||
There was a problem hiding this comment.
The reason I used the Ktor url here is that it is multiplatform. not sure is this should be avoided since this dependency will go to people not using ktor as well :/.
There was a problem hiding this comment.
this is ok,
this is part of core module.
...eptor-okhttp/lib/src/main/kotlin/com/pluto/plugins/network/internal/ResponseBodyProcessor.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.