Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create new API service #4

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Conversation

leowu0407
Copy link

Add GET & POST route
test

Copy link
Owner

@andy89923 andy89923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Unit Test for the service you add.

Comment on lines 49 to 50
applyRoutes(saoGroup, s.getSAORoute())
applyRoutes(saoGroup, s.postSAORoute())
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

combin to getSAORoute().
The get here is just get, not "GET" in http method.
You can refer to each NF

@andy89923 andy89923 changed the base branch from main to stu/113 September 25, 2024 03:32
Copy link
Owner

@andy89923 andy89923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflict by using rebase!

@andy89923 andy89923 merged commit 2129c5c into andy89923:stu/113 Oct 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants