-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create new API service #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add Unit Test for the service you add.
internal/sbi/router.go
Outdated
applyRoutes(saoGroup, s.getSAORoute()) | ||
applyRoutes(saoGroup, s.postSAORoute()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combin to getSAORoute()
.
The get here is just get, not "GET" in http method.
You can refer to each NF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflict by using rebase
!
Add GET & POST route
![test](https://private-user-images.githubusercontent.com/143949605/369914913-e4028d83-a59b-424b-a377-0a16c077573a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODI5ODAsIm5iZiI6MTczOTU4MjY4MCwicGF0aCI6Ii8xNDM5NDk2MDUvMzY5OTE0OTEzLWU0MDI4ZDgzLWE1OWItNDI0Yi1hMzc3LTBhMTZjMDc3NTczYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwMTI0NDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wYWVjNTk2ZDQ2Njk0NGQ3MDU3ODY0ZWRjODU3NWUyOTVkODQ2ZjVjODQ5ODY5YWM3YjVhZDc1NzFkYzAwNTlmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.6R6-Vg4mxempHVKDr8TYJsA2ad3jPLipBwEY6CfNQi8)