Enable set operations between AbstractIndices and abitrary itr
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyferris
approved these changes
Jun 2, 2022
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 77.08% 77.11% +0.02%
==========================================
Files 18 18
Lines 1999 2001 +2
==========================================
+ Hits 1541 1543 +2
Misses 458 458
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relaxes the types on the mutating methods of set operations so as to match the dispatch pattern in
Base. This means that set operations where the first argument is<:AbstractIndicesand the second is any validitrwill return anIndiceswith the result.Fix for #100