Bumps #57

jtojnar · 2024-09-22T21:58:34Z

Switch to poetry-core
Upgrade to Pydantic 2
Fix typing error

Current issues:

need to update lockfile
parso 0.8 no longer supports Python ≤ 3.5: https://github.com/davidhalter/parso/blob/v0.8.4/CHANGELOG.rst#080-2020-08-05

Whatever this is:

>       assert val == expected
E       AssertionError: assert '# type: (Cal...-> Types.NONE' == '# type: (Cal...int]) -> None'
E         
E         - # type: (Callable[[], int]) -> None
E         ?                                 ^^^
E         + # type: (Callable[[], int]) -> Types.NONE
E         ?                                ++++++ ^^^

tests/refactor/test_utils.py:149: AssertionError

waterloo/refactor/annotations.py:59: DeprecationWarning: `structlog.threadlocal` is deprecated, please use `structlog.contextvars` instead.

This is the current recommendation: https://python-poetry.org/docs/pyproject/#poetry-and-pep-517

- Used `bump-pydantic` - `BaseModel.__fields__` and `copy()` were deprecated in favour of `model_fields` and `model_copy()` respectively. - `BaseSettings` has been moved to the `pydantic-settings` package: https://docs.pydantic.dev/2.7/migration/#basesettings-has-moved-to-pydantic-settings - `FieldInfo.type_` is no longer available, must use `FieldInfo.annotation`: https://www.github.com/pydantic/pydantic/issues/7220

For some reason `@_repr_type_arg.register` annotation for `_` would fail: NameError: name 'ImportStrategy' is not defined

- Numbers are no longer coerced to strings by default, let’s revert that in config for now. https://docs.pydantic.dev/2.7/migration/#validator-behavior-changes

jtojnar added 3 commits September 22, 2024 22:22

Switch to poetry-core

d853bb6

This is the current recommendation: https://python-poetry.org/docs/pyproject/#poetry-and-pep-517

Fix typing error

72f66a0

For some reason `@_repr_type_arg.register` annotation for `_` would fail: NameError: name 'ImportStrategy' is not defined

jtojnar marked this pull request as draft September 22, 2024 21:58

squash! Upgrade to Pydantic 2

4822507

- Numbers are no longer coerced to strings by default, let’s revert that in config for now. https://docs.pydantic.dev/2.7/migration/#validator-behavior-changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bumps #57

Bumps #57

jtojnar commented Sep 22, 2024 •

edited

Loading

Bumps #57

Are you sure you want to change the base?

Bumps #57

Conversation

jtojnar commented Sep 22, 2024 • edited Loading

jtojnar commented Sep 22, 2024 •

edited

Loading