Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #185 #187

Closed
wants to merge 2 commits into from
Closed

Fix #185 #187

wants to merge 2 commits into from

Conversation

NycroV
Copy link
Collaborator

@NycroV NycroV commented Sep 23, 2024

Fixes the issue described in #185

We don't need to use the null check operator, as the result will always be null before assigning.
Document that the returned index is the index of the last track added to the queue if a playlist is passed, not the first.

Ex: queueing 5 tracks on a player that is currently playing, but has an empty queue, should return 5.

@NycroV NycroV linked an issue Sep 23, 2024 that may be closed by this pull request
Copy link

Delta Summary

Generated on: 09/23/2024 - 03:46
Description Previous Current Delta
Coverage date: 09/12/2024 - 18:05 09/23/2024 - 03:46
Line coverage: 64.5% 66.4% 1.9%
Covered lines: 17818 14694 -3124
Coverable lines: 27584 22106 -5478
Total lines: 60678 60595 -83
Branch coverage: 50.2% 51.2% 1.0%
Covered branches: 2534 2512 -22
Total branches: 5045 4901 -144
Method coverage: Feature is only available for sponsors

@NycroV NycroV closed this Sep 23, 2024
@NycroV NycroV deleted the nycrov/fix/185 branch September 23, 2024 03:51
@NycroV
Copy link
Collaborator Author

NycroV commented Sep 23, 2024

Oops, renamed the branch to be more in-line with existing branch naming, and it closed the PR.
Will re-open momentarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant