This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
Fixed event '_id' assignment. #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uncionality were being assigned different '_id' 's earlier.
|
If this fix gets accepted it is going to be my first Open-Source contribution! :) Had to learn how to fork and create PRs for contributing to existing great libraries like this. Something new learnt for me today. Cheers. |
…n the token. Checked for presence of _i attribute in the event since updation from fullcalendar of the dates to moment dates caused triggering of onChanged event.
|
Hey sorry about the delay on this. I like this PR, could you close and send another one with the same functionality? thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed event '_id' attribute assignment..
Events with same 'id' required for repeat functionality were being assigned different '_id' earlier.
This resulted in breaking functionality for fullcalendar's repeat event functionality wherein repeated events repositioning is supposed to reposition all events by the same day-difference-delta.