This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
Do not save dirty changes automatically when save plugin is present #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, can we please merge it 👍 |
|
I am not sure if this library is being maintained. I had created this PR long time ago but there hasn’t been any response since. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there is a 'save' plugin present in tinymce then the intention is to control the saving operation using a callback or saving via a button.
In the directive, debouncedUpdateTimer function is automatically saving the editor changes on a change event which should not happen if 'save' plugin is used. Due to this, save_onsavecallback callback is not getting called because there are no dirty changes.
Issue
#260
Plunkr link with the implemented changes
https://plnkr.co/edit/u3iFVfv8J3u95AAm14Rb?p=preview