This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
WIP(core): use asynchooks to resolve es2017 native async/await issue #984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #740, #715
use
async/hooks
to resolvees2017 native async/await
not in zone issue.Because
PromiseHook.kResolve
will only fire whenresolve
is called, we don't know whether or not the promise is really resolved or not, so we still need theZoneAwarePromise
monkey-patch.And I will remove other monkey-patch later to make an
asynchooks
based zone which isasynchooks
+ZoneAwarePromise
.setTimeout/setInterval...
will just useasynchooks
.now I made a basic test, when build in
es2017
, the code still in zone.