Return nothing if popup is not the desired purpose #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There are a lot of errors on this directive, like the use of
eval()
and many other little things...can be...
But, the main problem here is that
popup
is to generic! I've other package who use this HTML option (data-popup
) and without a test to be sure thatpopup_meta_data
is not undefined I've got a lot of error in my console.This is just a hack. But I think you need to remove completly this component and use some convention like
asm-popup
or whatever (sm-*
is used by the real Semantic-UI Angular component).