Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IParsable and IComparisonOperators from the IQuantity interface #1459

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

lipchev
Copy link
Collaborator

@lipchev lipchev commented Dec 16, 2024

Fixes #1454

@lipchev
Copy link
Collaborator Author

lipchev commented Dec 16, 2024

@angularsen This is not related to this PR but as of recently (I think) when the CodeGen generates the files (at least on my machine) I get a change in the Quantity.g.cs with regards to the encoding:

These files have different encodings. Left file: Unicode (UTF-8) with signature. Right file: Cyrillic (Windows). You can resolve the difference by saving the right file with the encoding Unicode (UTF-8) with signature.

If I covert the encoding (say using Notepad++) to UTF-8-BOM the file is removed from the change-list. Any ideas?

@lipchev
Copy link
Collaborator Author

lipchev commented Dec 16, 2024

@angularsen This is not related to this PR but as of recently (I think) when the CodeGen generates the files (at least on my machine) I get a change in the Quantity.g.cs with regards to the encoding:

These files have different encodings. Left file: Unicode (UTF-8) with signature. Right file: Cyrillic (Windows). You can resolve the difference by saving the right file with the encoding Unicode (UTF-8) with signature.

If I covert the encoding (say using Notepad++) to UTF-8-BOM the file is removed from the change-list. Any ideas?

Hm, this isn't happening after merging the changes from my other PR- something must have changed in the encoding there already..

@angularsen
Copy link
Owner

angularsen commented Dec 16, 2024

If I covert the encoding (say using Notepad++) to UTF-8-BOM the file is removed from the change-list. Any ideas?

Not sure, I usually work on Windows, are you on Linux or Mac?
Usually this happens when using non-UTF8 encoding for Norwegian characters æøå. It could be this, or some other characters that the file writer reconizes as non-UTF8 and decides to use Cyrillic encoding for.
What encoding are the other files?
Can we maybe enforce a particular encoding in the CodeGen?

@angularsen
Copy link
Owner

Aha, I do recall I found you had made some manual changes to this particular generated file, which I fixed by moving the code changes to the StaticQuantitySomething.cs file instead and running codegen. Maybe this fixed it.

@angularsen angularsen merged commit 623d195 into angularsen:release/v6 Dec 16, 2024
1 check passed
@lipchev
Copy link
Collaborator Author

lipchev commented Dec 16, 2024

Aha, I do recall I found you had made some manual changes to this particular generated file, which I fixed by moving the code changes to the StaticQuantitySomething.cs file instead and running codegen. Maybe this fixed it.

My hypothesis for this case was that I must have accidentally reverted the change in the StaticQuantityGenerator (the change was still there in my other solution).

In any case there isn't anything non-standard in terms of text in this file so I guess we'll see how it goes in the future...

PS I'm also a standard windows user...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants