-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add radiation equivalent dose rate #1464
Add radiation equivalent dose rate #1464
Conversation
Add radiation equivalent [dose rate](https://en.wikipedia.org/wiki/Dose_rate).
Add radiation equivalent [dose rate](https://en.wikipedia.org/wiki/Dose_rate). Port of #1464 to v6. - migrate .extra.cs files to UnitRelations.json --------- Co-authored-by: Alexander Voronische <[email protected]>
Thanks! I ported this to v6 branch also. Nuget should be out shortly. |
@angularsen As it stands, the For example, multiplying some PS I love how the build failed due to the lack of coverage of the operator (and the uncovered lines are finally showing up clearly)- it's very useful in highlighting issues like the one I spotted just now.. 👍 |
Gotcha, I was thinking about it, but didn't know if seconds made sense in this domain. A quick google reveals that there are conversions for Sievert/second, so sure, we can add that and set it as base unit I guess. |
Changed base unit here |
Fixup of #1464 - Add unit `SievertPerSecond`, for SI compatibility, with prefixes Nano, Micro, Milli - Change `RadiationEquivalentDoseRate` base unit from `SievertPerHour` to `SievertPerSecond` - Update conversion functions.
Sorry, I'm perhaps a little late for the party :), but. I'm working for the company related to measurement of radiation an I could say that the amount of Sieverts per seconds value could be too small even for Double unit - it's just no sense. I don't know internals of UnitsNet deeply. I added Sv(rem) per hour as base unit widely used in industry. |
Not late at all, I'm just pushing too fast here, sorry my bad. I did find references to Sievert/second, millisievert/second etc. so I assumed it would make sense to include it, mostly to have SI compatible units. I have no idea if these are reputable sources, but at least more than one source included it. |
Ok. Lets see how it will work. Thank you! |
Merged into V6 branch, nuget should be out shortly. |
Add radiation equivalent dose rate.