Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restricted domain to youtube #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

restricted domain to youtube #38

wants to merge 1 commit into from

Conversation

mfs12
Copy link

@mfs12 mfs12 commented Jan 30, 2021

Fixes #37.

@NathanJRollins
Copy link
Contributor

NathanJRollins commented Feb 1, 2021 •
edited
Loading

@animeshk @animeshkundu I have tested this, and it appears to work. Thanks, blnagain (:

This fixes #37, as mentioned by blnagain, but also fixes #33, #21, and #12, which are duplicate issues.

@immortaliseORdie
Copy link

immortaliseORdie commented May 30, 2021 •
edited
Loading

How do I change the extension to only have access to youtube? Can you please upload the code to firefox or is it already only accessing youtube?

@mfs12
Copy link
Author

mfs12 commented May 31, 2021

@qchristianp this pull request restricts domains to all needed so youtube continues to function properly.

@immortaliseORdie
Copy link

@mfs12 ok but I would like to understand if the current version downloadable on the addon store already has this restriction

@mfs12
Copy link
Author

mfs12 commented Jun 3, 2021

@qchristianp no it doesn't... check here https://github.com/animeshkundu/youtube-audio/blob/master/manifest.json the permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

restrict domain to youtube.com
3 participants
@mfs12 @NathanJRollins @immortaliseORdie