Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add eslint prettier #280

Closed

Conversation

ritik307
Copy link

@ritik307 ritik307 commented Jan 2, 2022

Description

Added eslint and prettier

Fixes #174

Type of Change:

  • Quality Assurance

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged
  • I have written Kotlin Docs whenever is applicable

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@ritik307 ritik307 requested a review from mtreacy002 as a code owner January 2, 2022 11:52
@welcome
Copy link

welcome bot commented Jan 2, 2022

Hello there!👋 Welcome to the project!💖

Thank you and congrats🎉 for opening your first pull request.✨ AnitaB.org is an inclusive community, committed to creating a safe and positive environment.🌸Please adhere to our Code of Conduct and Contribution Guidelines.🙌.We will get back to you as soon as we can.😄

Feel free to join us on AnitaB.org Open Source Zulip Community.💖 We have different streams for each active repository for discussions.✨ Hope you have a great time there!😄

@ritik307
Copy link
Author

ritik307 commented Jan 2, 2022

@vj-codes Can you kindly look into the PR as I am unable to figure out whats the issue is? The code is running well on my local machine but the build is failing somehow and I am not able to understand the issue.

@ritik307 ritik307 closed this Jan 2, 2022
@ritik307 ritik307 deleted the feature/add-eslint-prettier branch January 2, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA: Add a code formatter and code linter for standardizing the code style
1 participant