feat(migrations): Remove cacert.pem on version bump
#1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technically, the cert file is already being checked and copied whenever you open the player. But apparently there is some issue with that logic... Not sure what it is |
jmir1
approved these changes
Feb 19, 2025
Dark25
added a commit
to Animetailapp/Animetail
that referenced
this pull request
Feb 19, 2025
feat(migrations): Remove `cacert.pem` on version bump (aniyomiorg#1938)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how or why, but something goes wrong when updating the mpv-lib, causing users to get a malformed .pem file and being unable to play anything. We just need to remember to bump the app version whenever we update mpv-lib, or we could copy over the .pem file every time a video is loaded.