Update to FSRS-rs v1.1.4 #3329
Merged
Update to FSRS-rs v1.1.4 #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks as always Jarrett! I'll try to get to this tomorrow. Regarding the upgrade to Rust 1.80, in the future, I'd prefer FSRS maintain a 'minimum Rust version' policy that allows us to go 3 Rust versions back. There are some times when a Rust upgrade will break things (for example, dropping support for older OS versions), and if FSRS makes those changes before Anki is ready to, we won't be able to update to it. |
|
OK. Should I revert the version for FSRS-rs for this PR? |
|
It's probably fine this time, just a comment for the future. |
dae
added a commit
that referenced
this pull request
Aug 5, 2024
|
Sorry for the delay! |
|
Just a heads up: https://github.com/ankidroid/Anki-Android-Backend will need a similar toolchain update when the dependency is updated there (to rust ver 1.80) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: